rusackas commented on issue #25988: URL: https://github.com/apache/superset/issues/25988#issuecomment-2115783693
Right, the npm/webpack built assets are indeed included in the python package... which I thought was done via `npm run build` anyway... so it'd just be shifting it to that NPM process. This would just have the benefit for people cloning the repo from github, so they could just run `npm run build` to have the assets in their local builds. Doing so on `npm run dev(-server)` seems a bit heavy-handed, but also seems useful for those contributing translations. The NPM script _might_ even be able to check if you have translations turned on, and only run it if relevant. Maybe this is a good topic to discuss more synchronously :) It'd be great to get it all straightened out one way or another! :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
