justinpark opened a new pull request, #28795: URL: https://github.com/apache/superset/pull/28795
### SUMMARY Following up #24539 This commit modifies the `addQueryEditor` function to asynchronously handle the process of creating a queryEditor in localStorage in the same way as in non-persistent mode and periodically saving the queryEditor state to persistence via AutoSync's `migrateQueryEditorFromLocalStorage`. In persistence mode, new tabs can now open and access data directly from localStorage without the delays caused by network or database latency. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF * with network latency Before: https://github.com/apache/superset/assets/1392866/f07ea4e1-efcb-47b9-89f6-dfaa1726dcea After: https://github.com/apache/superset/assets/1392866/9f16fb8e-2a13-43dd-9e44-84631d5ac7a5 ### TESTING INSTRUCTIONS Set SQLLAB_PERSISTENCE_MODE on and then open a multiple tabs please reload the page and then check all tabs are persisted ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
