goldjee commented on PR #28572: URL: https://github.com/apache/superset/pull/28572#issuecomment-2152399966
@Atmostone My pleasure. Do you mean that you weren't able to find corresponding lines in messages.po file? I have stumbled upon several cases like that as well. For example, at "Create chart" page there is "or" that I wasn't able to translate. <img width="689" alt="Снимок экрана 2024-06-06 в 16 54 32" src="https://github.com/apache/superset/assets/7242338/39cbba73-ad87-4838-ba3c-bb8ff4aa8a61"> I don't know how to deal with such cases yet. Probably the code of the corresponding components don't take advantage of i18n system and should be modified in prior. Also, @mistercrunch @rusackas, will it be appropriate if I create a discussion to gather feedback like this on russian translation? I would like to tinker with it a bit more, as there is a lot of room for improvements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
