villebro commented on PR #29091: URL: https://github.com/apache/superset/pull/29091#issuecomment-2152995257
> @villebro Thank you for review. I wrote yesterday in slack channel. Maybe you missed it. The related MR that broke it is this: #28762 from @hanslemm. Seems like linting skipped on it: https://github.com/apache/superset/actions/runs/9381289976 @sabyrzhan oh, that skip on CI shouldn't have happened IMO (probably warrants looking into separately from this, though) 🙁 Do you think you'll be able to fix it as a bycatch here? I'm assuming it should be simple to fix. If not I can take a stab at it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
