Vitor-Avila opened a new pull request, #29229: URL: https://github.com/apache/superset/pull/29229
### SUMMARY This is a follow up for https://github.com/apache/superset/pull/29117, since it was confirmed on [this comment](https://github.com/apache/superset/pull/26654#issuecomment-2162050230) that the issue still persists. I'm updating these relationships to `viewonly=True`, since there's already an `after_delete` hook in place to delete tag association after an asset is deleted - [reference](https://github.com/apache/superset/blob/master/superset/tags/models.py#L276-L290). With that in mind, handling the cascade deletion in the relationship is redundant. Long-term, we could delete this hook and fix the relationships for a proper cascading deletion -- I'll look into that in a following PR (need to make sure that removing this hook won't impact any other logic in the application). ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF No UI changes. ### TESTING INSTRUCTIONS 1. Make sure you have a dashboard and a chart with the same ID. 2. Assign a tag for both assets. Also add owners to both assets. 3. Validate that you're able to delete one of the assets. ### ADDITIONAL INFORMATION - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
