john-bodley opened a new pull request, #29248: URL: https://github.com/apache/superset/pull/29248
<!--- Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/ Example: fix(dashboard): load charts correctly --> ### SUMMARY Man, the SQL Lab execution logic is a real rabbit warren—so many methods and diversions to execute SQL. https://github.com/apache/superset/pull/27725 _attempted_ to remove stripping comments when executing queries in SQL Lab, however it likely wasn't suffice. https://github.com/apache/superset/pull/28363 (which also preventing stripping of comments in Explore) remedied this, however it was later reverted in https://github.com/apache/superset/pull/28567. The original issue with https://github.com/apache/superset/pull/27725 is it seems like the SQL is pre-processed/rendered in the command prior to the typical SQL Lab execution logic via Celery et al. This PR simply ensures that comments are never stripped within the context of SQL Lab. This change shouldn't cause the issue surfaced in https://github.com/apache/superset/pull/28567. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TESTING INSTRUCTIONS <!--- Required! What steps can be taken to manually verify the changes? --> ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
