michael-s-molina commented on issue #29268: URL: https://github.com/apache/superset/issues/29268#issuecomment-2173637445
Thanks for the detailed SIP @geido and for leading the efforts to upgrade Ant Design. > As we upgrade Ant Design to version 5, it is critical to reassess these choices. Here is the proposed approach: > Strip All Custom Styles: > Integrate Ant Design Theme Correctly: > Showcase States in Storybook: > Reapply Essential Custom Styles: This is great! Get ready @kasiazjc! 😄 > Modifications to standard behaviors > Heavily leveraging component props to alter standard behaviors is common practice in Superset. However, this approach incurs high maintenance costs due to the challenges of upgrading to newer versions of Ant Design. When reading this, I was a little bit confused. Altering standard behaviors using Ant Design properties is ok as they are part of the API. I believe you meant that we pass properties to our custom components which override the Ant Design component using CSS styles instead of properties. If that's what you meant, then we can improve this paragraph to make it more clear. > Proposed Workflow Approach One suggestion I have is to create the PRs that upgrade a component as an atomic unit of work that can be reverted easily. This will allow us to require @kasiazjc's approval in each of these PRs, before merging them. We can use labels to block the merge button. > A list of all Ant Design components and where they are used. Is this list complete? I don't see Ant Design's Select component. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
