justinpark opened a new pull request, #29278: URL: https://github.com/apache/superset/pull/29278
### SUMMARY The current DB selection empty state screen is modified through the setEmptyState function. As a result, when tabs switch and share the same DB selection ID, the setEmptyState call is ignored, leading to a bug where the empty state is displayed even when a DB is selected. This commit unifies the state management by using useMemo to ensure that the showEmpty value is always set when there is a currently selected DB. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF Before: https://github.com/apache/superset/assets/1392866/289f3a10-0320-44e3-a98f-d62d9c6a7ed5 After: https://github.com/apache/superset/assets/1392866/94bd1629-7812-4910-90f3-e55b919a4d19 ### TESTING INSTRUCTIONS Open multiple tabs that selects the same db and then switch tabs each others ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Required feature flags: - [ ] Changes UI - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)) - [ ] Migration is atomic, supports rollback & is backwards-compatible - [ ] Confirm DB migration upgrade and downgrade tested - [ ] Runtime estimates and downtime expectations provided - [ ] Introduces new feature or API - [ ] Removes existing feature or API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
