villebro commented on code in PR #29088:
URL: https://github.com/apache/superset/pull/29088#discussion_r1644894896
##########
superset-frontend/src/features/alerts/AlertReportModal.tsx:
##########
@@ -1010,6 +1014,29 @@ const AlertReportModal:
FunctionComponent<AlertReportModalProps> = ({
return hasInfo;
};
+ const checkEmailFormat = () => {
+ if (!notificationSettings.length) {
+ return true;
+ }
+
+ const validateEmails = (emails: string): boolean => {
+ if (!emails) return true; // No emails to validate
+ return emails
+ .split(/[,;]/)
Review Comment:
Should we add whitespace?
```suggestion
.split(/[,\s;]/)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
