andy1xx8 opened a new issue, #29336:
URL: https://github.com/apache/superset/issues/29336

   ### Bug description
   
   Hi,
   The issue is the Clickhouse connector return sensitive detail: **IP & Port** 
 in the Superset UI dashboard
   Example:
   ```
   Error: HTTPDriver for http://10.15.27.43:8123 returned response code 404)
    Code: 60. DB::Exception: Table test.users_1 does not exist. Maybe you meant 
test.users? (UNKNOWN_TABLE) (version 23.12.3.40 (official build))
   ```
   the UI will show the **IP & Port** and event the **table** and **database** 
name then the hacker may use this to attack. 
   
   Furthermore, The dashboard viewer/creator I don't think the technical error 
message will help them.
   
   So I think we need to wrap the exception and give a better description for 
each error to the UI. 
   Beside that we will log the details of the original exception in the 
Superset backend side => So the admin they can debug and check the log later.
   By doing this, the UI will display  clean and clear.
   
    ## Summary
   <!-- A short description of the changes with a link to an open issue. -->
   
   ## Checklist
   Delete items not relevant to your PR:
   - [ ] Unit and integration tests covering the common scenarios were added
   - [ ] A human-readable description of the changes was provided to include in 
CHANGELOG
   - [ ] For significant changes, documentation in 
https://github.com/ClickHouse/clickhouse-docs was updated with further 
explanations or tutorials
   
   
   ### How to reproduce the bug
   
   1. Create a virtual dataset with Clickhouse Connection
   2. Build a simple dashboard with at least 1 chart using the above dataset.
   3. Change the database with a wrong name in SQL query. And save it
   4. Go to the dashboard and see the debug message log
   
   ### Screenshots/recordings
   
   ![Screenshot 2024-06-23 at 16 17 
04](https://github.com/apache/superset/assets/7830473/618155e3-16a1-4ee1-88fa-db83b1d42a27)
   
   
   ### Superset version
   
   4.0.1
   
   ### Python version
   
   3.9
   
   ### Node version
   
   16
   
   ### Browser
   
   Chrome
   
   ### Additional context
   
   _No response_
   
   ### Checklist
   
   - [ ] I have searched Superset docs and Slack and didn't find a solution to 
my problem.
   - [ ] I have searched the GitHub issue tracker and didn't find a similar bug 
report.
   - [ ] I have checked Superset's logs for errors and if I found a relevant 
Python stacktrace, I included it here as text in the "additional context" 
section.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to