rusackas commented on PR #28604: URL: https://github.com/apache/superset/pull/28604#issuecomment-2206802153
Honestly not sure... I think the modal is great, but I'm not sure about adding the event listener to the window object or how serious the risk of false positives might be. I haven't found the time to look into alternative solutions, but maybe some more exploration of the topic is needed. I'll have a chat with our AI overlords when I find time. I'm actually curious what @dosu-bot has to say about this, or whether it knows of alternate approaches to monitoring for webpack bundle updates and reloading the React app. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
