mistercrunch commented on issue #29462: URL: https://github.com/apache/superset/issues/29462#issuecomment-2206810589
hey, this is a bit confusing, but `BUILD_SUPERSET_FRONTEND_IN_DOCKER` affects a subsequent build step in `docker/docker-frontend.sh`, that's related to firing up `docker-compose`. The step you refer to above happens much earlier in the docker build process. Essentially our dev setup is based on our docker builds, and part of that multi-stage / target docker build that somewhere upstreams builds the frontend bundle, only to throw it away / redo it in the late `docker-compose` build step as `npm run dev`, which operates off a mount and removes the need for that upstream build. It would be nice to make that step optional upstream perhaps, but could create other kind of confusion an conflicts. Wondering if simply adding an ARG in our main dockerfile based on `BUILD_SUPERSET_FRONTEND_IN_DOCKER` would have any downsides (?) Also hoping that in many cases you could `docker pull` and operate from cache instead of locally building that layer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
