Vitor-Avila commented on code in PR #29412:
URL: https://github.com/apache/superset/pull/29412#discussion_r1669188176
##########
superset/views/base_api.py:
##########
@@ -180,8 +180,19 @@ class BaseTagFilter(BaseFilter): # pylint:
disable=too-few-public-methods
""" The Tag class_name to user """
model: type[Dashboard | Slice | SqllabQuery | SqlaTable] = Dashboard
""" The SQLAlchemy model """
+ id_based_filter = False
def apply(self, query: Query, value: Any) -> Query:
+ # ID based filter
+ if self.id_based_filter:
Review Comment:
Hey @hughhhh -- just added unit tests for the `BaseTagFilter` -- the
`ChartTagNameFilter`, `ChartTagIdFilter`, `DashboardTagNameFilter`,
`DashboardTagIdFilter`, `SavedQueryTagNameFilter` and `SavedQueryTagIdFilter`
should have integration tests already 🙌
Let me know if you have any other concerns or feedback 🙏
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
