mistercrunch commented on PR #29499: URL: https://github.com/apache/superset/pull/29499#issuecomment-2218259966
> These changes are useful in scenarios where we want to use the docker-compose setup together with an existing redis instance Are you secretly trying to use our docker-compose setup in production!? :) I'm not against making the dev setup more configurable, but the more we push in that direction, the harder it is to guarantee an simple `docker-compose up` that just works. Also adding logic/support for new env vars in docker-compose that diverge from what works in production isn't best. Portability of `.env`-type files and superset_config is good, and having support for a different set of env vars in dev/prod (like this PR does) isn't ideal. Why not simply improving the docs as to how to configure Redis in any superset_config file (production or dev), and clarifying how to alter docker-compose using `docker/superset_config_docker.py`? Seems you could simply move the custom code in this PR to a local superset_config and roll with it. About the idea of exposing more -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
