jzhao62 opened a new pull request, #27797:
URL: https://github.com/apache/superset/pull/27797

   **SUMMARY**
   - the previous practice involves auto auto populate database (stored in 
local storage) into the newly created dataset, which will create bugs when 
database name changes, database is deleted, or when database meta is changed.
   - the practice of saving and fetching latest modified database through 
localStorage is a potentially technical debut, making it easy to introduce 
regression that cannot be tracked. looking to potential bugs next.
   **BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF**
   stale database data in localStorage
   
![image](https://github.com/apache/superset/assets/25937657/b481506e-691b-40fa-889f-18562d9945c9)
   
   **after fix demo**
   
https://github.com/apache/superset/assets/25937657/8a20d1dc-cdb9-47a2-8cac-7d84b16eaa5a
   **TESTING INSTRUCTIONS**
   connect a database of your choice,
   rename your database
   create a new dataset, and you will see the option not prepopulated.
   **ADDITIONAL INFORMATION**
   [ x] Has associated issue: Fix 
https://github.com/apache/superset/issues/27266
    Required feature flags:
    Changes UI
    Includes DB Migration (follow approval process in 
https://github.com/apache/superset/issues/13351)
    Migration is atomic, supports rollback & is backwards-compatible
    Confirm DB migration upgrade and downgrade tested
    Runtime estimates and downtime expectations provided
    Introduces new feature or API
    Removes existing feature or API


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to