Vitor-Avila commented on code in PR #29530: URL: https://github.com/apache/superset/pull/29530#discussion_r1672305703
########## superset/security/manager.py: ########## @@ -145,9 +145,9 @@ def __init__(self, **kwargs: Any) -> None: RoleModelView.related_views = [] -def freeze_metric(metric: Metric) -> str: +def freeze_value(metric: Metric) -> str: Review Comment: Super nitpicky, but maybe we want to also change the parameter name from `metric` to something generic as well (such as `value`)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
