villebro commented on issue #29515: URL: https://github.com/apache/superset/issues/29515#issuecomment-2224979664
I feel the issue ultimately comes down to maintainability of the feature. Currently, the main issues that we're facing with synchronous queries are as follows: 1. no deduplication of queries 2. no mechanism for cancelling running queries 3. queries locking webserver threads, making it difficult to scale infra appropriately While the current WebSocket solution addresses the third point above, the other points are not addressed by the current solution, and in my experience, they're far more critical for enterprise deployments. I'm all for hardening and even expanding the use of WebSocket solution if we can find people to maintain and develop it further. However, given the low community involvement on the [`superset-websocket`](https://github.com/apache/superset/tree/master/superset-websocket) codebase, I feel the maintenance burden of this component exceeds the benefit of it in the current architecture. If we do feel WebSockets are critical for the future roadmap, I feel we still need to simplify the architecture, and support query deduplication and cancellation, as they are not within the scope of the current GAQ solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
