rusackas commented on code in PR #27456: URL: https://github.com/apache/superset/pull/27456#discussion_r1679831171
########## docs/docs/contributing/creating-viz-plugins.mdx: ########## @@ -35,7 +35,7 @@ version of the template that ships with the version of Superset you are using. T can be installed by doing the following: ```bash -npm i -g yo +npm i -g yo (If it is not working, use alternate command "npm i -g @superset-ui/generator-superset") Review Comment: The source code is actually what's in the Superset repo. The Superset repo is a monorepo, meaning the contents of the `packages` and `plugins` folders _should_ be periodically published to NPM. We aren't doing this as often as we ought to, but there's been little outcry over it, so it doesn't get prioritized. If what's in the repo isn't working, then we should fix it, and publish a new version of the generator. I'm having second thoughts about even HAVING the generator at this point, since it's painful to maintain. A very vanilla example plugin in a folder in the codebase would be a LOT easier to maintain, as a "starter kit" In the meantime, I approved this PR as it's far more helpful than harmful, but it needs a rebase to be mergeable. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
