michael-s-molina commented on code in PR #29604:
URL: https://github.com/apache/superset/pull/29604#discussion_r1679969029


##########
superset/models/core.py:
##########
@@ -993,7 +993,7 @@ def get_schema_access_for_file_upload(  # pylint: 
disable=invalid-name
                 self, g.user
             )
             allowed_databases += extra_allowed_databases
-        return sorted(set(allowed_databases))

Review Comment:
   Should the frontend change also happen in this PR to make it atomic? This 
would make the PR not only fix the list issue but also preserve the current 
sorted behavior.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org

Reply via email to