geido commented on code in PR #29264:
URL: https://github.com/apache/superset/pull/29264#discussion_r1680950410
##########
superset/tasks/scheduler.py:
##########
@@ -94,7 +94,7 @@ def execute(self: Celery.task, report_schedule_id: int) ->
None:
).run()
except ReportScheduleUnexpectedError:
logger.exception(
- "An unexpected occurred while executing the report: %s", task_id
+ "An unexpected error occurred while executing the report: %s",
task_id
Review Comment:
Nice catch
##########
superset/utils/slack.py:
##########
@@ -31,6 +46,80 @@ def get_slack_client() -> WebClient:
return WebClient(token=token, proxy=current_app.config["SLACK_PROXY"])
+def get_channels_with_search(
Review Comment:
So bad that we need this function that seems prone to errors but if Slack
does not allow searching, then we are out of luck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
