codecov[bot] commented on PR #29281: URL: https://github.com/apache/superset/pull/29281#issuecomment-2233979146
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/29281?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report Attention: Patch coverage is `81.25000%` with `3 lines` in your changes missing coverage. Please review. > Project coverage is 64.97%. Comparing base [(`76d897e`)](https://app.codecov.io/gh/apache/superset/commit/76d897eaa2f9e137102bc194c2e3109c29d0348f?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`2a92fa0`)](https://app.codecov.io/gh/apache/superset/commit/2a92fa0ba83306d61cad59b17f0fa06afc4d8192?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). > Report is 460 commits behind head on master. | [Files](https://app.codecov.io/gh/apache/superset/pull/29281?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines | |---|---|---| | [superset/models/core.py](https://app.codecov.io/gh/apache/superset/pull/29281?src=pr&el=tree&filepath=superset%2Fmodels%2Fcore.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | 66.66% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/29281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | | [superset/utils/database\_connect\_modifier.py](https://app.codecov.io/gh/apache/superset/pull/29281?src=pr&el=tree&filepath=superset%2Futils%2Fdatabase_connect_modifier.py&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQvdXRpbHMvZGF0YWJhc2VfY29ubmVjdF9tb2RpZmllci5weQ==) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/29281?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | <details><summary>Additional details and impacted files</summary> ```diff @@ Coverage Diff @@ ## master #29281 +/- ## ========================================== + Coverage 60.48% 64.97% +4.48% ========================================== Files 1931 525 -1406 Lines 76236 37797 -38439 Branches 8568 0 -8568 ========================================== - Hits 46114 24558 -21556 + Misses 28017 13239 -14778 + Partials 2105 0 -2105 ``` | [Flag](https://app.codecov.io/gh/apache/superset/pull/29281/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | |---|---|---| | [hive](https://app.codecov.io/gh/apache/superset/pull/29281/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `49.13% <81.25%> (-0.03%)` | :arrow_down: | | [javascript](https://app.codecov.io/gh/apache/superset/pull/29281/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | | | [presto](https://app.codecov.io/gh/apache/superset/pull/29281/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `53.71% <81.25%> (-0.10%)` | :arrow_down: | | [python](https://app.codecov.io/gh/apache/superset/pull/29281/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `64.97% <81.25%> (+1.48%)` | :arrow_up: | | [unit](https://app.codecov.io/gh/apache/superset/pull/29281/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `59.87% <81.25%> (+2.24%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more. </details> [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/29281?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
