fisjac commented on code in PR #29096:
URL: https://github.com/apache/superset/pull/29096#discussion_r1689035765
##########
superset/commands/report/execute.py:
##########
@@ -168,15 +168,15 @@ def _get_url(
force=force,
**kwargs,
)
-
# If we need to render dashboard in a specific state, use stateful
permalink
- if dashboard_state := self._report_schedule.extra.get("dashboard"):
+ if (
+ dashboard_state := self._report_schedule.extra.get("dashboard")
+ ) and feature_flag_manager.is_feature_enabled("ALERT_REPORT_TABS"):
Review Comment:
My rationale for hiding that functionality behind the `ALERT_REPORT_TABS` FF
was that if a report was saved with an `extra` parameter, then the FF was
turned off, there would no longer be an interface for viewing/updating the
currently selected tab. It seemed more intuitive to have the behavior default
to ignoring the `extra` parameter altogether while the FF was disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
