kgabryje commented on PR #29787: URL: https://github.com/apache/superset/pull/29787#issuecomment-2260916473
> While I understand the need for this, the idea here was that you could use any Antd icon without having to specify it again. Not sure if there is a way around that to keep that functionality available. Yes I know that the component is now going to be harder to use, but I don't see any other way to fix the problem. Due to the dynamic nature of defining icons, webpack had no way of guessing which icons are actually used, so we ended up with a huge chunk containing every icon in antd. We don't add new icons that often, so I think it won't be a big overhead to add a new icon to the import list once in a while. It's "lesser evil" compared to the performance decrease that we suffer from it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
