mistercrunch commented on code in PR #29688:
URL: https://github.com/apache/superset/pull/29688#discussion_r1699068273
##########
.github/workflows/tag-release.yml:
##########
@@ -54,10 +54,13 @@ jobs:
- name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
uses: actions/checkout@v4
with:
- persist-credentials: false
- tags: true
fetch-depth: 0
+ - name: Use Node.js 20
Review Comment:
yeah `supersetbot` requires 20 as I'm using some of the newer ecmascript
features and didn't want to set up babel. If I remember well I think that was
just the from `import ... from ...` synthax that force me up to 20. No way I
was going to deal with `require()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
