mistercrunch commented on issue #26395: URL: https://github.com/apache/superset/issues/26395#issuecomment-2261426967
+1 on moving forward. Few other thoughts while the discussion is still open: - **about WHEN to fetch the metadata client-side:** I think realistically, most of the fetching of metadata should 1. be done at "user clicks expand" time, though upon expanding a database connection we could fetch 2 layers (catalog + schema) right off the bat. That has clear implication for searching as we'd probably limit to what's in context client-side - for that I think the `text-muted` for unloaded items makes it clear enough that we won't search *within* those objects - **about caching**: we should cache every "expand" call here (when expanding a database, a schema, or a table), but we should also expose a way to force-refresh as often in a SQL IDE people are creating tables, adding columns to table, ... - **about action buttons:** I also would prefer a more subtle, icon-shown-on-hover approach like we haven now instead of large `primary` buttons like shown in the designs - **about metadata**: I don't think we currently do a good job at fetching/surfacing table-level or column-level comments/description, I'd love to have better support for not only showing it, but maybe even making it easy to add/commit descriptions from SQL Lab - this probably out-of-scope for this SIP One last note is that we have a "metadata well" currently that's used to show some metadata in some database engine, things like "latest partition" and "table description". I think that belongs somewhere under individual tables and close to the action buttons -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
