denodo-research-labs commented on issue #20656: URL: https://github.com/apache/superset/issues/20656#issuecomment-2262206097
We are actually adapting our infrastructure to 4.0 and 4.1 and intended to create a PR in a matter of days. It would include: - The db_engine_spec (`denodo.py`) - The instalaltion of our [denodo-sqalchemy package](https://pypi.org/project/denodo-sqlalchemy/) In order to do the latter, we did the following in our internal fork: - Add the version specification of the dependency in `setup.py` - Added the dependency in `requirements/local.in` and `requirements/local.txt` But also, we needed to do this in `Dockerfile` in order for this dependency to be installed correctly, because we didn't find `local.txt` to be taken into account: ```dockerfile #> [denodo-removed] # RUN --mount=type=bind,target=./requirements/base.txt,src=./requirements/base.txt \ # --mount=type=bind,target=./requirements/docker.txt,src=./requirements/docker.txt \ # --mount=type=cache,target=/root/.cache/pip \ # pip install -r requirements/docker.txt #> ---- #> [denodo-added] RUN python -m pip install --upgrade pip RUN cd /app \ && pip install --no-cache -r requirements/docker.txt \ && pip install --no-cache -r requirements/local.txt || true #> ---- ``` Are we installing this dependency properly, would you advise a different approach? Any further instructions about how to prepare our artifacts for the PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
