rusackas commented on PR #29822: URL: https://github.com/apache/superset/pull/29822#issuecomment-2263628011
Thank you so much for this! Looks like it's working fine. It _might_ need a rebase to pick up a CI fix from another PR, and it looks like it has some linting issues, which can be resolved with our pre-commit hooks. Superset uses Git pre-commit hooks courtesy of [pre-commit](https://pre-commit.com/). To install run the following: ``` pip3 install -r requirements/development.txt pre-commit install A series of checks will now run when you make a git commit. ``` Alternatively it is possible to run pre-commit by running pre-commit manually: ``` pre-commit run --all-files ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org