eschutho commented on code in PR #29721: URL: https://github.com/apache/superset/pull/29721#discussion_r1700879414
########## pyproject.toml: ########## @@ -230,6 +230,7 @@ module = "tests.*" check_untyped_defs = false disallow_untyped_calls = false disallow_untyped_defs = false +disable_error_code = "annotation-unchecked" Review Comment: This was needed to skip the error: `note: By default the bodies of untyped functions are not checked, consider using --check-untyped-defs [annotation-unchecked]` It seems like it should be covered in `check_untyped_defs = false` but it is not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org