Re: [PR] fix: Add user filtering to changed


marre commented on PR #29287:
URL: https://github.com/apache/superset/pull/29287#issuecomment-2264821230


   @sadpandajoe Would really love to have this in 4.1...
   
   @bruno-santos-6 What version of superset are you testing with?
   
   Just pulled latest from superset/superset (master branch)
   
   # Without EXTRA_RELATED_QUERY_FILTERS
   
   Without EXTRA_RELATED_QUERY_FILTERS configured:
   
   Owner:
   
![image](https://github.com/user-attachments/assets/a738f0d7-7bf3-460e-bcf1-fc86272b0735)
   
   Modified-by:
   
![image](https://github.com/user-attachments/assets/a663898d-fdaf-46ff-866f-bae79d9ef7c5)
   
   # With EXTRA_RELATED_QUERY_FILTERS
   
   Added this to my superset_config.py:
   ```
   def user_filter(query):
       from sqlalchemy.sql import false
       return query.filter(false())
   
   EXTRA_RELATED_QUERY_FILTERS = {
       "user": user_filter,
   }
   ```
   
   Started with:
   ```
   export SUPERSET_CONFIG_PATH=./superset_config.py
   superset run -p 8088 --with-threads --reload --debugger --debug
   ```
   
   Owner after:
   
![image](https://github.com/user-attachments/assets/4663f2fa-8244-46b7-8eff-4beb9a4b3994)
   
   Modified-by after:
   
![image](https://github.com/user-attachments/assets/3bfbd7d0-2723-4631-8be0-194f0c0fdc23)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Re: [PR] fix: Add user filtering to changed_by. Fixes #27986 [superset]

Reply via email to