graceguo-supercat edited a comment on issue #7348: Feature flag for client cache URL: https://github.com/apache/incubator-superset/pull/7348#issuecomment-486027143 logic here is very confusing: https://github.com/apache/incubator-superset/blob/5f28027ce745dfda67e18fe7df8468184400be50/superset/assets/src/chart/Chart.jsx#L73 User needs to dig 2 layers down to figure out which one overwrite which... Could you consolidate this logic a little bit? Otherwise I see i am calling `getSavedChart` but actually `postChartFormData` is get called 🙈 We should not ask other developers to find all different pieces for this GET vs POST logic.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
