mistercrunch commented on code in PR #29868:
URL: https://github.com/apache/superset/pull/29868#discussion_r1704710517
##########
.github/workflows/superset-python-misc.yml:
##########
@@ -1,53 +0,0 @@
-# Python Misc unit tests
-name: Python Misc
-
-on:
- push:
- branches:
- - "master"
- - "[0-9].[0-9]*"
- pull_request:
- types: [synchronize, opened, reopened, ready_for_review]
-
-# cancel previous workflow jobs for PRs
-concurrency:
- group: ${{ github.workflow }}-${{ github.event.pull_request.number ||
github.run_id }}
- cancel-in-progress: true
-
-jobs:
- python-lint:
- runs-on: ubuntu-22.04
- steps:
- - name: "Checkout ${{ github.ref }} ( ${{ github.sha }} )"
- uses: actions/checkout@v4
- with:
- persist-credentials: false
- submodules: recursive
- - name: Check for file changes
- id: check
- uses: ./.github/actions/change-detector/
- with:
- token: ${{ secrets.GITHUB_TOKEN }}
- - name: Setup Python
- uses: ./.github/actions/setup-backend/
- if: steps.check.outputs.python
Review Comment:
`python-lint` doesn't actually lint, it does nothing. All the linting is in
pre-commit now, see this section here ->
https://github.com/apache/superset/blob/master/.pre-commit-config.yaml#L74-L93
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
