kgabryje commented on PR #29874: URL: https://github.com/apache/superset/pull/29874#issuecomment-2271869157
> Super nice work, improvements on many levels here! One final thing that comes to mind is maybe adding a linting rule to block direct imports of `echarts`. Other than that LGTM! Good idea! Let me do that in a separate PR 🙂 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
