mistercrunch commented on PR #29586:
URL: https://github.com/apache/superset/pull/29586#issuecomment-2274319141

   Hey I pulled your branch and still see as though you didn't run the newer 
version of `./scripts/translations/babel_update.sh` which includes the  
`--no-location` flag. You can see it in your local branch it looks like this:
   
   <img width="929" alt="Screenshot 2024-08-07 at 1 42 51 PM" 
src="https://github.com/user-attachments/assets/048e5439-f5da-4c98-ae97-d4b029919745";>
   
   But if you can run the **latest version** of 
`./scripts/translations/babel_update.sh`, there shouldn't be all these [purple 
in my screenshot] comments referencing where that msgid lives. See how these 
comments aren't there in the `master` branch of the file you are changing -> 
https://github.com/apache/superset/blob/master/superset/translations/ar/LC_MESSAGES/messages.po


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to