justinpark opened a new pull request, #29900:
URL: https://github.com/apache/superset/pull/29900

   ### SUMMARY
   Following up #27645, This commit includes the migration of the component 
used for SQLLab results from the ant-table component to the ag-grid component.
   During this process, the existing logic(`getWidthsForColumns`) that measured 
column size to adjust the width was removed because it was not only 
performance-intensive but also unnecessary, as the resizable column option in 
ag-grid allows users to adjust the width as needed.
   Additionally, other property options were modified to ensure compatibility 
with ag-grid. Moreover, a column menu feature was added, enabling users to pin 
specific columns and apply filters.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before:
   
   ![Screenshot 2024-08-09 at 7 33 03 
AM](https://github.com/user-attachments/assets/adebb248-e4ec-4cd0-aac2-b88bbdab00cc)
   
   After:
   
   ![Screenshot 2024-08-09 at 11 40 35 
AM](https://github.com/user-attachments/assets/22b9d6e2-bda9-4db9-a47b-82b27d51360b)
   
   Header menu (Actions):
   
   
![Image](https://github.com/apache/superset/assets/1392866/82185b00-29ea-406b-b07b-fc0d58fd4255)
   
   
   ### TESTING INSTRUCTIONS
   
   Go to SQL Lab and run a query to explore the data
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [x] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to