michael-s-molina opened a new pull request, #29906:
URL: https://github.com/apache/superset/pull/29906
### SUMMARY
Fixes a error when downgrading revision `58d051681a3b`. The previous code
was invoking `downgrade_catalog_perms` after dropping the `catalog_perm` column
which is used by that function, generating an error:
```
op.drop_column("slices", "catalog_perm")
op.drop_column("tables", "catalog_perm")
downgrade_catalog_perms(engines={"postgresql"})
```
This PR also rewrites revision `5f57af97bc3f` to remove duplicated code.
### TESTING INSTRUCTIONS
Check both upgrade and downgrade operations for each migration.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
