villebro commented on code in PR #29911:
URL: https://github.com/apache/superset/pull/29911#discussion_r1714182842
##########
superset/db_engine_specs/couchbase.py:
##########
@@ -74,14 +74,15 @@ class CouchbaseParametersSchema(Schema):
)
-class CouchbaseDbEngineSpec(BasicParametersMixin, BaseEngineSpec):
- engine = "couchbasedb"
+class CouchbaseEngineSpec(BasicParametersMixin, BaseEngineSpec):
+ engine = "couchbase"
+ engine_aliases = {"couchbase", "couchbasedb"}
Review Comment:
The failed MySQL test is flaky - we can restart the test. The docs one seems
unrelated - It seems `resources/INTHEWILD.md` has a link to `/www.cnovit.com`
that isn't working. I think we may need to remove the link if the homepage
isn't up anymore. Do you want to do it in this PR? I can also open a PR to fix
it if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
