villebro opened a new pull request, #29997:
URL: https://github.com/apache/superset/pull/29997
### SUMMARY
When running `superset db upgrade` on my local devenv, the `87ffc36f9842`
migration errored out on the following Trino connection string:
`trino://trino@localhost:8081`.
### AFTER
**executes successfully**
### BEFORE
```python
File
"/Users/ville/apple/apache-superset/superset/migrations/versions/2024-05-09_18-44_87ffc36f9842_enable_catalog_in_bigquery_presto_trino_.py",
line 36, in upgrade
upgrade_catalog_perms(engines={"trino", "presto", "bigquery",
"snowflake"})
File
"/Users/ville/apple/apache-superset/superset/migrations/shared/catalogs.py",
line 384, in upgrade_catalog_perms
if default_catalog := database.get_default_catalog():
File "/Users/ville/apple/apache-superset/superset/models/core.py", line
580, in get_default_catalog
return self.db_engine_spec.get_default_catalog(self)
File
"/Users/ville/apple/apache-superset/superset/db_engine_specs/presto.py", line
306, in get_default_catalog
return database.url_object.database.split("/")[0]
AttributeError: 'NoneType' object has no attribute 'split'
```
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in
[SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
