Antonio-RiveroMartnez opened a new pull request, #30002:
URL: https://github.com/apache/superset/pull/30002

   ### SUMMARY
   The time comparison feature that's being used in Table and Big Number charts 
does not support Human Readable dates and it's very limited on what date 
formats it  supports. 
   
   Now the API supports sending `inherit` or a `YYYY-MM-DD` date as offset 
value so we can rely on the existing API to parse any date before computing the 
custom or inherit offset.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before
   <img width="1670" alt="error" 
src="https://github.com/user-attachments/assets/96aa0f2a-94fd-4b9b-a4e3-6e9bb148263e";>
   
   
   Now
   <img width="1670" alt="test" 
src="https://github.com/user-attachments/assets/ae3106b3-12bf-443a-b0d2-d732632f8319";>
   
   
   ### TESTING INSTRUCTIONS
   1. Set up a Table Chart with a date filter with value: `Aug 2024` until 
`tomorrow``
   2. Select inherit time shift
   3. The chart must display the correct data and the comparison label
   
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to