elukey opened a new pull request #7379: Add condition in WorldMapViz before using Pandas' iloc URL: https://github.com/apache/incubator-superset/pull/7379 Recent pandas versions (0.23+) changed the value of df[metric] when the same metric is used in a World Map panel for both bubble size and an axis (either X or Y). This change adds some guards before using panda's iloc to avoid exceptions. Should fix #7006 ### CATEGORY Choose one - [x] Bug Fix - [ ] Enhancement (new features, refinement) - [ ] Refactor - [ ] Add tests - [ ] Build / Development Environment - [ ] Documentation ### SUMMARY WorldMap charts, using the the same metric for X/Y axis and bubble size, are not working anymore from 0.29+ due to a change in numpy/pandas. I verified that I am using the versions indicated in Superset's requirement.txt. ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF <!--- Skip this if not applicable --> ### TEST PLAN ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [ ] Has associated issue: - [ ] Changes UI - [ ] Requires DB Migration. - [ ] Confirm DB Migration upgrade and downgrade tested. - [ ] Introduces new feature or API - [ ] Removes existing feature or API ### REVIEWERS
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
