villebro commented on code in PR #29912: URL: https://github.com/apache/superset/pull/29912#discussion_r1714434237
########## superset/async_events/async_query_manager.py: ########## @@ -16,18 +16,27 @@ # under the License. import logging import uuid -from typing import Any, Literal, Optional +from typing import Any, Dict, Literal, Optional, Union Review Comment: nit: we can now use `dict` and `|` in type annotations as long as we do the following import at the beginning: ```python from __future__ iimport annotations ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
