kgabryje commented on code in PR #30027:
URL: https://github.com/apache/superset/pull/30027#discussion_r1734880288
##########
superset-frontend/src/features/databases/DatabaseModal/DatabaseConnectionForm/index.tsx:
##########
@@ -161,7 +65,7 @@ const DatabaseConnectionForm = ({
Object.keys(parameters.properties).includes(key) ||
key === 'database_name',
).map(field =>
- FORM_FIELD_MAP[field]({
+ (FORM_FIELD_MAP as any)[field]({
Review Comment:
Do we need that `as any`? If typescript is complaining, maybe we should
rather cast field as one of `FORM_FIELD_MAP`'s keys?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org
