dosubot[bot] commented on issue #30040: URL: https://github.com/apache/superset/issues/30040#issuecomment-2315736997
<!-- Greeting --> Hey @torbenw! I'm here to help with any bugs, questions, or contributions you have for the project. Let's squash those bugs together! 🤖 <!-- Answer --> I found a similar open issue that might be relevant to your problem: [Can't use cross-filtering on a column from a table whose name has been overridden](https://github.com/apache/superset/issues/24836). The suggested solution in that issue is to allow for a UI-only change in the "Customize column" section instead of renaming the columns in SQL. This approach could potentially address the problem you're facing with the column labels not updating in the table view. Additionally, there are existing unit tests that cover the functionality of renaming column labels in the "custom sql" tab. These tests ensure that the label updates correctly when switching to the SQL tab and saving the changes. You can find these tests in the following files: 1. `superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.test.tsx` <sup>[[1]](https://github.com/apache/superset/blob/master/superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.test.tsx)</sup>. 2. `superset-frontend/packages/superset-ui-core/test/query/getColumnLabel.test.ts` <sup>[[2]](https://github.com/apache/superset/blob/master/superset-frontend/packages/superset-ui-core/test/query/getColumnLabel.test.ts)</sup>. The key differences between the "simple" column mode and the "custom sql" mode in terms of label customization and display are as follows: - **Simple Mode**: Automatically sets the label based on the selected column's name. - **Custom SQL Mode**: Allows for manual label customization and displays a SQL editor for custom expressions <sup>[[3]](https://github.com/apache/superset/blob/master/superset-frontend/src/explore/components/controls/DndColumnSelectControl/ColumnSelectPopover.tsx)</sup>. The column label update process in the context of the "custom sql" tab is implemented using the `assign_column_label` function, which ensures that the column names in the DataFrame correspond to what is expected by the visualization components <sup>[[4]](https://github.com/apache/superset/blob/master/superset/models/helpers.py)</sup>. You might want to check if the label update process is correctly implemented in your setup and if the UI-only change approach could be a viable solution for your issue. <!-- Dosu Comment Footer --> *To continue talking to [Dosu](https://dosu.dev), mention @dosu.* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org For additional commands, e-mail: notifications-h...@superset.apache.org
