rusackas commented on PR #28796: URL: https://github.com/apache/superset/pull/28796#issuecomment-2315928823
Hey @sadpandajoe and @michael-s-molina thanks for the heads-up on both counts. I just opened a [revert](https://github.com/apache/superset/pull/30041)... seems like the right move since this was a touchup, but caused regressions. I'll open a new PR with this fix, and more through manual and/or scripted testing. The null checks were due to some situation (maybe automated tests?) where the properties were displayed for a `null` slice... but that was back in May and I don't remember the details any more. When I open the revised PR, I'll take those out and see what breaks... maybe there's a better workaround. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
