villebro commented on code in PR #28008:
URL: https://github.com/apache/superset/pull/28008#discussion_r1737872013
##########
tests/integration_tests/datasets/commands_tests.py:
##########
@@ -587,6 +618,7 @@ def test_create_dataset_command(self):
self.assertEqual([owner.username for owner in table.owners],
["admin"])
db.session.delete(table)
+ db.session.commit()
Review Comment:
Is this intermediate commit really needed? I would assume not, or at most a
flush. But do correct me if I'm wrong here!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
