mistercrunch commented on a change in pull request #7376: Fixing the examples
URL:
https://github.com/apache/incubator-superset/pull/7376#discussion_r278653461
##########
File path: tests/core_tests.py
##########
@@ -291,7 +291,8 @@ def test_slices(self):
]
for name, method, url in urls:
logging.info(f'[{name}]/[{method}]: {url}')
- self.client.get(url)
+ resp = self.client.get(url)
+ self.assertEqual(resp.status_code, 200)
Review comment:
This is important! This is the test that runs every single example chart,
and calls both `explore` and `explore_json` for each one. We were getting 500s
before this, and tests were passing...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
