abhioncbr commented on issue #7372: 7366: Added requirements-fill.txt file having mandatory & optional pa… URL: https://github.com/apache/incubator-superset/pull/7372#issuecomment-486832008 Thanks, @villebro & @mistercrunch for sharing the feedback. @mistercrunch, yes I wanted to have such a feature for docker. I can understand with a slim docker image reasoning, and people can install required packages on top of it, but over the time I realized that users/people don't want to put much effort in enhancing docker image. My intent of starting a Superset docker image repo is to have one image which can be leveraged for learning/exploration as well as putting the same into the production system. Recently, realized new releases of Superset is getting slimmer(which is good), for example, Flower package is optional now, and I have to install explicitly in later versions of docker image which makes much harder to manage DockerFile. Hence, I want all the packages i.e, mandatory & optional ones in Superset codebase so that it would be easier to install(not for me, for other guys too). Does it make sense? Yes, the checked-in file created manually, and I like the idea which you proposed for managing the requirements. Several 'requirements.in' files in the 'requirement' folder with the output text files. I will make the changes as per suggestion. Thanks.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
