jdbertron edited a comment on issue #6544: Make owner a m2m relation on 
datasources
URL: 
https://github.com/apache/incubator-superset/pull/6544#issuecomment-486868558
 
 
   Nah, that's not a viable solution for a production environment. The issue is 
actually not with this migration, but 
cefabc8f7d38_increase_size_of_name_column_in_ab_view_.py. The problem is that 
connections created during the app creation in superset init, (with all the 
stuff it does to create roles) is never released and the connection holds a 
metadata lock on ab_view_menu. The cefab.. migration can't run the ALTER until 
the connection is killed manually. The simplest way I found to fix it is to run 
the AppBuilder creation within the app context. Then when the context goes out 
of scope the sessions are released to the pool correctly by the __exit__ event 
handling, and the migration runs fine. I'll push the fix.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to