justinpark opened a new pull request, #30171:
URL: https://github.com/apache/superset/pull/30171

   ### SUMMARY
   Since `destroyInactiveTabPane` is disabled for improving rendering perf on 
switching tabs in 
[#26791](https://github.com/apache/superset/pull/26791/files#diff-f62a410d38c860c568090a5f5c0f0a3e2a3f621162ec665fa35ce17977cc34b0L284),
 I have confirmed that the Ace Editor was monitoring and responding to events 
even on inactive tabs.
   As a result, race conditions related to the cursor position were occurring 
when switching between tabs. This commit addresses these issues by modifying 
the behavior so that, similar to `destroyInactiveTabPane`, the Ace Editor 
component is excluded when a tab becomes inactive.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   
   
https://github.com/user-attachments/assets/57f06042-dfb4-467a-a305-f6f899c643b4
   
   Active:
   
   
https://github.com/user-attachments/assets/98c1ead8-7531-452f-b0c8-26ebbde0751f
   
   ### TESTING INSTRUCTIONS
   Specs are added
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [ ] Changes UI
   - [ ] Includes DB Migration (follow approval process in 
[SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to