justinpark commented on code in PR #29654:
URL: https://github.com/apache/superset/pull/29654#discussion_r1746297128
##########
superset-frontend/packages/superset-ui-core/src/chart/models/ChartProps.ts:
##########
@@ -105,6 +105,8 @@ export interface ChartPropsConfig {
inputRef?: RefObject<any>;
/** Theme object */
theme: SupersetTheme;
+ /** Set chart data selectable by user */
+ dataSelectionMode?: string;
Review Comment:
It seems more appropriate to pass a more shareable value like canExportData
rather than sending specific data selection values, and then set it according
to each component's needs.
```suggestion
canExportData: boolean;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
