Re: [PR] chore(sqllab): Add shortcuts for switching tabs [superset]

Fri, 06 Sep 2024 10:26:51 -0700 


justinpark commented on code in PR #30173:
URL: https://github.com/apache/superset/pull/30173#discussion_r1747480819


##########
superset-frontend/src/SqlLab/components/KeyboardShortcutButton/index.tsx:
##########
@@ -51,6 +53,8 @@ export const KEY_MAP = {
   [KeyboardShortcut.CtrlT]: userOS !== 'Windows' ? t('New tab') : undefined,
   [KeyboardShortcut.CtrlP]: t('Previous Line'),
   [KeyboardShortcut.CtrlShiftF]: t('Format SQL'),
+  [KeyboardShortcut.CtrlLeft]: t('Switch to the previous tab'),
+  [KeyboardShortcut.CtrlRight]: t('Switch to the next tab'),

Review Comment:
   FYI: The key mapping on this section has been implemented to be 
automatically added to the Keyboard Shortcut menu.
   ![Screenshot 2024-09-06 at 10 24 31 
AM](https://github.com/user-attachments/assets/fc7e61d4-0a69-4843-9d11-998671b9975f)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to